18.0.4 release

ChangeLog

@@ -1,3 +1,11 @@
+14-MAY-2022: 18.0.4
+
+- Fixes type error for diffsync with overlays [2808]
+- Handles possible error 400 in OneDrive auth flow
+- Fixes update of cell metadata in CSV import [2796]
+- Applies URL filtering checks to location header in java proxy
+- Resolves URL parameters in java proxy before filtering
+
 11-MAY-2022: 18.0.3
 
 - Removes remote cursor options from context menu

VERSION

@@ -1 +1 @@
-18.0.3
+18.0.4

src/main/webapp/electron.js

@@ -1884,9 +1884,15 @@ function windowAction(method)
 	}
 }
 
+const allowedUrls = /^(?:https?|mailto|tel|callto):/i;
+
 function openExternal(url)
 {
-	shell.openExternal(url);
+	//Only open http(s), mailto, tel, and callto links
+	if (allowedUrls.test(url))
+	{
+		shell.openExternal(url);
+	}
 }
 
 function watchFile(path)

src/main/webapp/js/diagramly/ElectronApp.js

@@ -85,13 +85,15 @@ mxStencilRegistry.allowEval = false;
 	var oldWindowOpen = window.open;
 	window.open = async function(url)
 	{
-		if (url != null && url.startsWith('http'))
+		// Only open a native electron window when url is empty. We use this in our code in several places.
+		if (url == null)
 		{
-			await requestSync({action: 'openExternal', url: url});
+			return oldWindowOpen(url);
 		}
 		else
 		{
-			return oldWindowOpen(url);
+			// Open external will filter urls based on their protocol
+			await requestSync({action: 'openExternal', url: url});
 		}
 	}
 

src/main/webapp/js/grapheditor/Graph.js

@@ -1664,7 +1664,7 @@ Graph.removePasteFormatting = function(elt)
 Graph.sanitizeHtml = function(value, editing)
 {
 	return DOMPurify.sanitize(value, {ADD_ATTR: ['target'], FORBID_TAGS: ['form'],
-		ALLOWED_URI_REGEXP: /^(?:(?:(?:f|ht)tps?|mailto|tel|callto|cid|xmpp|data):|[^a-z]|[a-z+.\-]+(?:[^a-z+.\-:]|$))/i});
+		ALLOWED_URI_REGEXP: /^(?:(?:https?|mailto|tel|callto|data):|[^a-z]|[a-z+.\-]+(?:[^a-z+.\-:]|$))/i});
 };
 
 /**

src/main/webapp/resources/dia.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_am.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_ar.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_bg.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_bn.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_bs.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_ca.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_cs.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_da.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_de.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_el.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_eo.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_es.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_et.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_eu.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_fa.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_fi.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_fil.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_fr.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_gl.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_gu.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_he.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_hi.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_hr.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_hu.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_i18n.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=confAFileCleaned
 confAFileCleanFailed=confAFileCleanFailed
 confACleanOnly=confACleanOnly
 brush=brush
+openDevTools=openDevTools

src/main/webapp/resources/dia_id.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_it.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_ja.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_kn.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_ko.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=임시 저장 다이어그램 "{1}" 을 삭제하였습니다.
 confAFileCleanFailed=임시 저장 다이어그램 "{1}" 삭제를 실패하였습니다.
 confACleanOnly=임시 저장된 다이어그램만 삭제
 brush=브러시
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_lt.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_lv.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_ml.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_mr.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_ms.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_my.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_nl.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Oude versies opgeschoond van diagram concept "{1}"
 confAFileCleanFailed=Oude versies opschonen van diagram concept "{1}" mislukt
 confACleanOnly=Alleen diagram concepten opschonen
 brush=Kwast
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_no.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_pl.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_pt-br.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_pt.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_ro.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_ru.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_si.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_sk.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_sl.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_sr.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_sv.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_sw.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_ta.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_te.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_th.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_tr.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_uk.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Чищення старих версій чернеток ді
 confAFileCleanFailed=Чищення старих версій чернеток діаграми '{1}' не вдалося
 confACleanOnly=Чистити тільки чернетки діаграм
 brush=Пензлик
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_vi.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_zh-tw.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=筆刷
+openDevTools=Open Developer Tools

src/main/webapp/resources/dia_zh.txt

@@ -1196,3 +1196,4 @@ confAFileCleaned=Cleaning diagram draft "{1}" done
 confAFileCleanFailed=Cleaning diagram draft "{1}" failed
 confACleanOnly=Clean Diagram Drafts Only
 brush=Brush
+openDevTools=Open Developer Tools