Browse Source

several small refactorings

Jakob Pietron 3 years ago
parent
commit
2eeaca1349

+ 5 - 5
src/frontend/rountangleEditor/RountangleComponent.tsx

@@ -17,11 +17,11 @@ export class RountangleComponent extends React.Component<RountangleProps, Rounta
     private rountangleRef: React.RefObject<HTMLDivElement>
 
     shouldComponentUpdate(nextProps: Readonly<RountangleProps>, nextState: Readonly<RountangleState>, nextContext: any): boolean {
-        return this.props.posX !== nextProps.posX
-            || this.props.posY !== nextProps.posY
-            || this.props.posZ !== nextProps.posZ
-            || this.props.width !== nextProps.width
-            || this.props.height !== nextProps.height
+        return this.props.posX     !== nextProps.posX
+            || this.props.posY     !== nextProps.posY
+            || this.props.posZ     !== nextProps.posZ
+            || this.props.width    !== nextProps.width
+            || this.props.height   !== nextProps.height
             || this.state.dragging !== nextState.dragging;
     }
 

+ 0 - 1
src/frontend/rountangleEditor/RountangleEditor.tsx

@@ -18,7 +18,6 @@ export class RountangleEditor extends React.Component<{}, RountangleEditorState>
         this.state = {store: new RountangleStore()};
         this.state.store.dispatch({tag: 'createRountangle', id: generateRandomGUID(), posX: 10,  posY: 50, posZ: 10, width: 100, height: 66, name:'ABC'});
         this.state.store.dispatch({tag: 'createRountangle', id: generateRandomGUID(), posX: 250, posY: 50, posZ: 10, width: 100, height: 66, name:'DEF'});
-
     }
 
     componentDidMount() {

+ 6 - 6
src/frontend/rountangleEditor/RountangleStore.ts

@@ -2,12 +2,12 @@ import {RountangleAction} from "./RountangleActions";
 import {assertNever} from "../../util/assert";
 
 export interface Rountangle {
-    name:   string;
-    posX:   number;
-    posY:   number;
-    posZ:   number;
-    width:  number;
-    height: number;
+    readonly name:   string;
+    readonly posX:   number;
+    readonly posY:   number;
+    readonly posZ:   number;
+    readonly width:  number;
+    readonly height: number;
 }
 
 export class RountangleStore {