#28 Complicated use of ValueError

Open
opened 3 years ago by rparedis · 0 comments

Description:

All errors in the simulator make use of the ValueError, which may cause some confusion. It might be better to split these into multiple custom errors for a more fine-grained approach.

All these errors should also automatically be logged to the logger.

Examples:

  • InvalidAlgebraicLoopError to be raised when a loop solver cannot solve the loop.
  • AlgebraicLoopError to be raised when a loop solver encounters an error in solving the loop. I.e., singular matrices, unknown elements, delayblock being used at time > 0...
  • CBDError when there is an error in the Core
  • DependencyGraphError
  • RungeKuttaError
  • SignalError when block gets invalid input during simulation
  • ...
**Description:** All errors in the simulator make use of the `ValueError`, which may cause some confusion. It might be better to split these into multiple custom errors for a more fine-grained approach. All these errors should also automatically be logged to the logger. **Examples:** - [ ] `InvalidAlgebraicLoopError` to be raised when a loop solver cannot solve the loop. - [ ] `AlgebraicLoopError` to be raised when a loop solver encounters an error in solving the loop. I.e., singular matrices, unknown elements, delayblock being used at time > 0... - [ ] `CBDError` when there is an error in the `Core` - [ ] `DependencyGraphError` - [ ] `RungeKuttaError` - [ ] `SignalError` when block gets invalid input during simulation - ...
Sign in to join this conversation.
No Label
BUG
No Milestone
No assignee
1 Participants
Loading...
Cancel
Save
There is no content yet.