Переглянути джерело

#366 : cleanup AbstractXpandBasedCodeGenerator (avoid duplicate
initialization of FSA), remove comments

Johannes Dicks 9 роки тому
батько
коміт
5054ec4ca8

+ 0 - 1
plugins/org.yakindu.sct.generator.core/src/org/yakindu/sct/generator/core/impl/AbstractSGraphModelGenerator.java

@@ -50,7 +50,6 @@ public abstract class AbstractSGraphModelGenerator implements ISCTGenerator {
 	protected ISCTFileSystemAccess sctFsa;
 
 	protected void runGenerator(Statechart statechart, GeneratorEntry entry) {
-		//FIXME JDI will that piece of code ever be called?! I cannot find an implementation of ISGraphGenerator
 		if (this instanceof ISGraphGenerator) {
 			ISGraphGenerator graphGenerator = (ISGraphGenerator) this;
 			graphGenerator.generate(statechart, entry);

+ 0 - 9
plugins/org.yakindu.sct.generator.core/src/org/yakindu/sct/generator/core/impl/AbstractXpandBasedCodeGenerator.java

@@ -25,10 +25,8 @@ import org.eclipse.xpand2.output.PostProcessor;
 import org.eclipse.xtend.expression.Variable;
 import org.eclipse.xtend.typesystem.Type;
 import org.eclipse.xtend.typesystem.emf.EmfRegistryMetaModel;
-import org.eclipse.xtext.generator.IFileSystemAccess;
 import org.yakindu.base.base.BasePackage;
 import org.yakindu.base.types.TypesPackage;
-import org.yakindu.sct.generator.core.features.ICoreFeatureConstants;
 import org.yakindu.sct.model.sexec.ExecutionFlow;
 import org.yakindu.sct.model.sexec.SexecPackage;
 import org.yakindu.sct.model.sgen.GeneratorEntry;
@@ -114,13 +112,6 @@ public abstract class AbstractXpandBasedCodeGenerator extends AbstractSExecModel
 	}
 
 	protected Output createOutput(GeneratorEntry entry) {
-		// FIXME JDI unify, this is duplicate see ...Java*Generic*Something
-		sctFsa.setOutputPath(ICoreFeatureConstants.OUTLET_FEATURE_TARGET_PROJECT,
-				outletFeatureHelper.getTargetProjectValue(entry).getStringValue());
-
-		sctFsa.setOutputPath(IFileSystemAccess.DEFAULT_OUTPUT,
-				outletFeatureHelper.getTargetFolderValue(entry).getExpression().toString());
-
 		String outputPath = outletFeatureHelper.getRelativeTargetFolder(entry);
 
 		String absoluteTargetFolder = sctFsa.getURI(outputPath).toFileString();

+ 1 - 1
plugins/org.yakindu.sct.generator.core/src/org/yakindu/sct/generator/core/util/EFSHelper.java

@@ -34,9 +34,9 @@ import org.yakindu.sct.model.sgen.GeneratorEntry;
 
 import com.google.inject.Inject;
 
-//FIXME JDI integrate dependent classes with ISCTFileSystemAccess?!
 /**
  * Encapsulates some EFS related functionality which can be used by Generators.
+ * 
  * @author Johannes Dicks - Initial contribution and API
  *
  */