Browse Source

reworded final state validation

Axel Terfloth 7 years ago
parent
commit
9f2a996960

+ 5 - 5
plugins/org.yakindu.sct.model.sgraph/src/org/yakindu/sct/model/sgraph/validation/FinalStateValidator.java

@@ -16,18 +16,18 @@ import org.yakindu.sct.model.sgraph.FinalState;
 
 /**
  * 
- * All validation contraints for the meta model element {@link FinalState}
+ * All validation constraints for the meta model element {@link FinalState}
  * 
  */
 public class FinalStateValidator extends AbstractSGraphValidator {
 
-	private static final String FINAL_STATE_NO_OUT_TRANSITION_MSG = "A final state must not have outgoing transitions.";
-	public static final String FINAL_STATE_NO_OUT_TRANSITION_CODE = "finalstate.NoOutTransitions";
+	private static final String FINAL_STATE_TRANSITIONS_NO_OUT_MSG = "A final state should not have outgoing transitions.";
+	public static final String FINAL_STATE_TRANSITIONS_NO_OUT_CODE = "finalstate.NoOutTransitions";
 
 	@Check(CheckType.FAST)
-	public void checkNoOutTransitions(FinalState finalState) {
+	public void checkFinalStateTransitionsNoOut(FinalState finalState) {
 		if ((finalState.getOutgoingTransitions().size() > 0)) {
-			warning(FINAL_STATE_NO_OUT_TRANSITION_MSG, finalState, null, -1, FINAL_STATE_NO_OUT_TRANSITION_CODE);
+			warning(FINAL_STATE_TRANSITIONS_NO_OUT_MSG, finalState, null, -1, FINAL_STATE_TRANSITIONS_NO_OUT_CODE);
 		}
 	}
 

+ 3 - 3
test-plugins/org.yakindu.sct.model.sgraph.test/src/org/yakindu/sct/model/sgraph/test/validation/FinalStateNoOutTransitionsValidatorTest.java

@@ -10,7 +10,7 @@
  */
 package org.yakindu.sct.model.sgraph.test.validation;
 
-import static org.yakindu.sct.model.sgraph.validation.FinalStateValidator.FINAL_STATE_NO_OUT_TRANSITION_CODE;
+import static org.yakindu.sct.model.sgraph.validation.FinalStateValidator.FINAL_STATE_TRANSITIONS_NO_OUT_CODE;
 
 import org.junit.Test;
 import org.yakindu.sct.model.sgraph.FinalState;
@@ -66,7 +66,7 @@ public class FinalStateNoOutTransitionsValidatorTest extends AbstractSGraphValid
 		createTransition(state, finalState);
 		createTransition(finalState, state);
 
-		tester.validate(finalState).assertWarning(FINAL_STATE_NO_OUT_TRANSITION_CODE);
+		tester.validate(finalState).assertWarning(FINAL_STATE_TRANSITIONS_NO_OUT_CODE);
 	}
 
 	/**
@@ -87,6 +87,6 @@ public class FinalStateNoOutTransitionsValidatorTest extends AbstractSGraphValid
 		createTransition(finalState, state);
 		createTransition(finalState, state);
 
-		tester.validate(finalState).assertWarning(FINAL_STATE_NO_OUT_TRANSITION_CODE);
+		tester.validate(finalState).assertWarning(FINAL_STATE_TRANSITIONS_NO_OUT_CODE);
 	}
 }